librdmacm/preload.c: fix duplicate symbol definitions on armhf#1746
Merged
Conversation
hector-cao
force-pushed
the
fix-preload-build-error
branch
3 times, most recently
from
621bd3d to
d8e37c3
Compare
Member
|
Please add Fixes line above your Signed-off-by: Fixes: 85f9747 ("librdmacm: Add support for fcntl64") |
85f9747 introduces the preload of fcntl64 and it fails to build on armhf: Assembler messages: Error: symbol `__fcntl_time64' is already defined Error: symbol `sendfile64' is already defined On armhf (and potentially other 32 bits systems), glibc directs fcntl64 and fcntl to the same symbol name. preload.c defines both fcntl and fcntl64 and these 2 implementations are in fact tight to the same symbol, that causes the double symbol error. So only provide the definition of both fcntl and fcntl64 if they are 2 separate symbols. This fixes the issue both for sendfile64 and fcntl64. Fixes: 85f9747 ("librdmacm: Add support for fcntl64") Signed-off-by: Hector Cao <hector.cao@canonical.com>
hector-cao
force-pushed
the
fix-preload-build-error
branch
from
d8e37c3 to
d20d0da
Compare
Contributor
Author
done, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
85f9747 introduces the preload of fcntl64 and it fails to build on armhf:
Assembler messages:
Error: symbol
__fcntl_time64' is already defined Error: symbolsendfile64' is already definedOn armhf, glibc defines both fcntl64 and fcntl as alias to __fcntl_time64. As a consequence, in preload.c, 2 function definitions of fcntl64 and fcntl are preprocessed to become the same function __fcntl_time64 definition, that cause the double symbol error.
Only define and intercept these functions if they are not already defined.
This fixes the issue both for sendfile64 and fcntl64.